Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that base64 URL padding on the service component of Method 2 … #52

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

swcurran
Copy link
Collaborator

…must NOT be padded

The pad characters ("=") in base64 encodings are not permitted in a DID. This is mentioned in the text, but emphasis is added. The examples had padding, so those have been removed.

@Jsyro, can you please confirm in your test setup that the regex values you are using still work.

…must NOT be padded

The pad characters ("=") in base64 encodings are not permitted in a DID.  This is mentioned in the text, but emphasis is added.  The examples had padding, so those have been removed.

@Jsyro, can you please confirm in your test setup that the regex values you are using still work.

Signed-off-by: Stephen Curran <[email protected]>

Signed-off-by: Stephen Curran <[email protected]>
@dhh1128 dhh1128 merged commit a70884c into decentralized-identity:master Jun 22, 2023
@Jsyro
Copy link

Jsyro commented Jun 22, 2023

By removing the padding, both the peer-did python library and the pydid library accepted the did:peer:2 correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants